Hi Tim, Why do be_find_current_be() and be_activate_current_be() return boolean_t and not the errors from the libzfs (passed through zfs_err_to_be_err) call or the error returned from _be_activate? I think that at least be_activate_current_be() should return the error passed back from _be_activate().
It just seems odd that these two functions are returning true/false. Thanks, -evan Tim Knitter wrote: > > Dave Miner wrote: >> Tim S. Knitter wrote: >>> Can someone please review the following? >>> >>> 1868 beadm destroy creates an empty grub menu >>> >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1868 >>> http://cr.opensolaris.org/~tsk/1868_slim/ >>> >> The fix seems a little problematic yet. The sequencing you've chosen >> here means that if we fail to activate the current menu item (which, >> though fairly unlikely, is certainly possible), then we still end up >> with a GRUB menu without an active entry. I'd rather we did things in >> an order that made that not possible. >> > > I fixed this in the latest webrev. If you could verify when you can find a > spare moment, I'd appreciate it. > > Thanks > Tim > >> Dave > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
