Ethan Quach wrote:
>
>
> Sundar Yamunachari wrote:
>>>
>>> SliceInfo_t struct:
>>> - the mountPoint member doesn't seem to belong in this struct.
>>> These Disk/Partition/Slice structures all seem to hold data
>>> describing physical attributes. Knowledge of where a slice is
>>> mounted should be at the software or OS level. Is there a
>>> reason why you choose to put this here?
>> I agree. It was added initially to help to find out whether root was
>> mounted and intend to be mounted on this slice. Also to see what is
>> mounted on each slice.
>>>
>>> upgradeInfo struct:
>>> - don't we need a type specifier the specify the type of union?
>> Can you explain?
>
> You need a type specifier to tell you if the SolarisInstance member is
> a UfsInstance or a ZfsInstance.
I got it. It needs a instance type. I will update the structure.
ZFSInstance is a place holder and is not complete.
>
> e.g.
>
> typedef struct upgradeInfo {
> InstanceType type;
> union {
> UfsInstance unifo;
> ZfsInstance zinfo;
> } SolarisInstance;
> ...
> ..
> .
> } UpgradeInfo_t;
>
>>> - nit: zonesConfigured should be changed to zonesInstalled
>> Configured sounds better since for creating zones, you are not
>> installing from a media.
>
> In the context of an UpgradeInfo object, zones in Configured state
> have no bearing on whether the instance of solaris is upgradeable,
> zones in Installed state do. I figured it'd be better to use the same
> semantics as to not cause confusion as to which zones trigger this
> flag to be set.
Okay. I will change it to zones_installed.
Thanks,
Sundar
