Sundar,
Thanks for the quick review again.
John
Sundar Yamunachari wrote:
> usr/src/cmd/installadm/list.py:
> 375: weather --> whether
Corrected.
> 364 def get_menu_info(path, witharch = True):
> What is the use of witharch here? Are you using arch from the calling
> place?
Right. I have removed the witharch references. During one of
the iterations I stopped using it and forgot to remove it. The
code now assumes that since we are getting the information from
the menu it is x86.
> 647-650: The comment indicates that this function is getting the size of
> the longest service name where as the function name indicates that it is
> finding 'calculate_client_name_widths'. I am confused. Which is correct?
I can see how that would be confusing. I have changed the name to be:
calculate_client_service_name_widths()
And updated the comments to be:
Iterates over the client dictionary calculating the maximum
service name length.
Args
ldict = dictionary of clients on a host with the
service name as the dictionary key
(same as in get_clients() description)
> - Sundar
