Jack, This change looks good.
- Keith Jack Schwartz wrote: > Hi everyone. > > Here is a small code review to fix*: > *13167 - Retrieving values via ManifestRead socket vs Distribution > Constructor's in-memory map returns different results > > Currently, ManifestRead returns a single value of "(empty string)" > when one or more nodes with empty string values match a requested > nodepath. The fix is to instead return as many empty strings as are > found. This behavior mimics what ManifestServ returns under the same > circumstances. > > Please see the bug report for the gory details: > http://defect.opensolaris.org/bz/show_bug.cgi?id=13167 > > Code review: > http://cr.opensolaris.org/~schwartz/091208.1/webrev/index.html > > Testing: > - Build and verified a usable live CD image. (Verified DC didn't break) > - Glenn (the bug filer) verified that the fix works for his VMC case > as well. > > Please review by Friday 12/11 lunchtime PST. > > Thanks, > Jack > > ------------------------------------------------------------------------ > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
