HI Dave. Thanks for your review.
Dave Miner wrote: > Jack Schwartz wrote: > ... > >> Please review at http://cr.opensolaris.org/~schwartz/080404.1/review >> >> TreeAcc.py is the module. A few test programs and a test XML file are >> also there for demo/experimentation. >> >> > > Not much that I could find, just a few nits > > TreeAcc.py > > 269-271: stylistically it may be better to split these across two lines > OK. Done. > 333: is there a reason why this and the other static methods don't have > the @staticmethod decorator? > Yeah... I didn't know about it :) ... Seriously, thanks for the tip. Updated. > 393: "methods" > Fixed > 531,631: commented-out code left > Removed > 789: continuation indent > Fixed. Will putback with these changes. Thanks, Jack > Dave > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
