thx....I'll look at that and make the appropriate changes.
ginnie
Dave Miner wrote:
> Virginia Wray wrote:
>> Here is an updated webrev with the suggested changes incorporated.
>> I'm especially interested to know if I implemented the code involving
>> (INS.file) correctly in the SUNWdistro-license makefile.
>> I wasn't sure if I made it more complicated than necessary.
>>
>
> I would have expected
>
> FILES += $(LICENSE)
>
> and to have listed $(ROOTLICENSE) as a dependency for the install
> target, not all.
>
> You shouldn't need the LICENSE reference on line 42.
>
>> Another note, I didn't remove the keywords for
>> usr/src/pkgdefs/Makefile and usr/src/pkgdefs/Makefile.targ.*
>> *I'll catch them when I work on the bug relating to removing those. I
>> did go ahead and remove them on the SUNWdistro-license files
>> added with this bug fix.
>
> I would have just removed them, but your choice, I guess.
>
> Dave
>
>> thx,
>> ginnie
>>
>> webrev:
>> http://cr.opensolaris.org/~ginnie/webrev/
>>
>>
>> Dave Miner wrote:
>>> Virginia Wray wrote:
>>>> Hi -
>>>>
>>>> Could someone take a look at this bug fix?
>>>>
>>>> Bug:
>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=511
>>>> Summary: Move SUNWdistro-license to slim_source repo
>>>>
>>>> webrev:
>>>> http://cr.opensolaris.org/~ginnie/webrev/511/
>>>>
>>> Makefile.targ: You shouldn't put package-specific targets here, only
>>> general targets that are designed to be shared, so this should be
>>> moved into SUNWdistro-license/Makefile. I see Sanjay suggested
>>> using $(CP), but I would suggest instead $(INS.file) as the correct
>>> action, with FILEMODE set appropriately.
>>>
>>> In all the new files (actually all of them period), please remove
>>> the SCCS keywords.
>>>
>>> Dave
>>
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
--
Ginnie
