Hi Matt, Thanks for the review. There is no scrolled window here in this case because we require the disk icons to be scrollable but don't want the disk status notification area beneath the icons to scroll - It's supposed to have a hover over type of effect. The scrollbar beneath is a seperate widget item and is connected to the viewport containing the disk icons manually via. a GtkAdjustment. This requires you to manage the scrollbar visibility manually since only the scrolledwindow widget provides this automatic convenience.
Thanks, Niall. On Mon, 2008-03-10 at 13:13 +0000, Matt Keenan wrote: > Changes all look fine, just curious as to why you have to manually check the > size of the release notes screen and the hiding/showing of the scrollbar. > Can this not be done automatically by the scrolledwindow widget ? > > Matt > > > Niall Power wrote: > > Hi, > > > > requesting code review for the following bugs: > > 514 : Release notes handling in installer needs to be better > > 531 : Scrollbar in hard disk dialog always shown > > 703 : Welcome screen and release name out of sync with UI spec. > > > > http://defect.opensolaris.org/bz/show_bug.cgi?id=514 > > http://defect.opensolaris.org/bz/show_bug.cgi?id=531 > > http://defect.opensolaris.org/bz/show_bug.cgi?id=703 > > > > Webrev of changes is available at: > > http://cr.opensolaris.org/~niall/bugs-514x531x703/ > > > > Overview of changes: > > > > usr/src/cmd/inst/gui-install/src/callbacks.c > > Removed the switch check for initial installation vs. inplace upgrade when > > progressing to the next screen from the welcome screen. It will always be > > initial installation. Note that this does not remove all of the upgrade > > specific > > code, only the pieces relating to the selection on the welcome screen. A > > seperate bug needs to be file to completely remove all code related to > > upgrade > > functionality. > > > > usr/src/cmd/inst/gui-install/src/confirmation-screen.c > > usr/src/cmd/inst/gui-install/src/failure.glade > > usr/src/cmd/inst/gui-install/src/finish-screen.c > > usr/src/cmd/inst/gui-install/src/installation-screen.c > > Updated release name to OpenSolaris 2008.05 > > > > > > usr/src/cmd/inst/gui-install/src/gui-install.glade > > Updated release name to OpenSolaris 2008.05 > > Removes the radio buttons from the welcome screen and updates the text and > > layout > > in accordance with the latest UI spec. > > > > usr/src/cmd/inst/gui-install/src/installation-disk-screen.c > > Adds a callback to catch when the adjustment range of the scrollbar changes > > ("changed" > > signal). Checks the adjustment rage compared to it's page size and hides > > the scrollbar if range <= page size which means scrolling is unnecessary. > > Shows the scrollbar otherwise. > > > > usr/src/cmd/inst/gui-install/src/installationdisk.glade > > Fixes a layout issue in the disk view. Provide 6 pixel vertical and > > horizontal padding > > around the disk icons. Also make the disk status notification area have a 6 > > pixel padding. > > Most of the diff is just noise from the autogenerated glade file. > > > > usr/src/cmd/inst/gui-install/src/interface-globals.h > > Remove release notes text file definitions. Will be replaced soon via an > > orchestrator provided API to determine release notes URL. > > > > usr/src/cmd/inst/gui-install/src/main.c > > Updated release name to OpenSolaris 2008.05 > > Removed release notes text file path setup > > > > usr/src/cmd/inst/gui-install/src/welcome-screen.c > > Removed callbacks handlers for install and upgrade radio buttons. > > Remove release notes dialog callbacks and unnecessary initialisation > > function. > > Use URL handler instead (gnome_url_open_on_screen()) to open release > > notes instead of popping up a text dialog. > > > > usr/src/cmd/inst/gui-install/src/welcome-screen.h > > Removed releasenotes dialog and radio button widget structure members. > > Temporarily hardcode the release notes URL until an API mechanism is > > available. > > > > Thanks, > > Niall. > > -- > > This message posted from opensolaris.org > > _______________________________________________ > > caiman-discuss mailing list > > caiman-discuss at opensolaris.org > > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > >
