On 3/10/08, Dave Miner <dminer at opensolaris.org> wrote: > Anil Gulecha wrote: > > On 3/10/08, Dave Miner <dminer at opensolaris.org> wrote: > >> Anil Gulecha wrote: > >> > Hi, > >> > > >> > Please review the code changes for bug 700. This was caused due to > >> > touch failing as it doesnt exist at this stage of bootup. > >> > > >> > http://cr.opensolaris.org/~anilg/700_v01/ > >> > > >> > >> > >> Why not use something like: > >> > >> /sbin/mount|grep ^/.cdrom > >> > >> rather than using a marker file for the mount succeeding? > >> > > > > Done. > > http://cr.opensolaris.org/~anilg/700_v02/ > > > > My testing involved editing the microroot in the DP2 generated USB and > > successfully booting it. I've been unable to build Indiana using DC, > > and I'll try to get that working tomorrow. > > > > > I'll build an image with this version to verify, anyway. > > > > I've also edited usbgen and removed the microroot patching code, as it > > is unnecessary (listusb is also present in /sbin by default, so I'm > > not sure why it was being copied). These changes are also in the > > review. > > > > > Since usbgen is in a different repository at the moment > (distro_constructor, not slim_prototype), let's handle that one as a > separate bug/review. >
[reply all] Ok. Undid the usbgen changes. Latest review at http://cr.opensolaris.org/~anilg/700_v03/ Anil
