Hi, requesting code review for bug 758: add timezone support to the installer http://defect.opensolaris.org/bz/show_bug.cgi?id=758
Webrev of changes is at: http://cr.opensolaris.org/~jedy/bug-758/ Overview 4 new source files(map.c, map.h, timezone.c, timezone.h) and several png files are added. usr/src/cmd/inst/gui-install/src/date-time-zone.glade Pack 3 combo boxes into a toplevel window to make it easier to integrate it into the timezone widget. Removed some redundant widgets. usr/src/cmd/inst/gui-install/src/datetimezone-screen.h usr/src/cmd/inst/gui-install/src/interface-globals.h Modified DateTimeZoneWindowXML and MainWindowXML and add some new #define. usr/src/cmd/inst/gui-install/src/datetimezone-screen.c Move the old implementation of timezone combo boxes to timezone.c. usr/src/cmd/inst/gui-install/src/map.c usr/src/cmd/inst/gui-install/src/map.h Implementation of map widget. The widget shows the map and load timezones from system. Some interfaces used by timezone widget are also implemented. usr/src/cmd/inst/gui-install/src/timezone.c usr/src/cmd/inst/gui-install/src/timezone.h Implementation of timezone widget. The widget includes map widget and timezone combo boxes. usr/src/cmd/inst/gui-install/src/main.c Removed redundant code and a redundant variable of g_signal_connect. Regards, Jedy -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20080313/a0f5b11d/attachment.html>
