HI Niall, The patch looks fine to me.
Regards, Jedy On Fri, 2008-03-14 at 21:13 -0700, Niall Power wrote: > Hi, > > Requesting code review for bug 772: Installer GUI should use unified logging > service (liblogsvc) > > http://defect.opensolaris.org/bz/show_bug.cgi?id=772 > > Webrev of changes is at: > http://cr.opensolaris.org/~niall/bug-772-a > > Overview of changes: > One of the issues that needs to be addressed with the switch to using > liblogsvc, > and away from the default logging service (g_log) provided by glib is that all > underlying modules and libraries in the GUI's GNOME based stack make use of > it. > > We need to capture all of the underlying logging and debugging messages in > the > GNOME stack and pass them through to the logsvc methods. This can be achieved > by > registering a default logging handler in the GUI code. This is already done, > but currently it clones the default output format of g_log and sends it to > /tmp/gui_install.log instead of stdout/stderr. > The best way to fix this therefore is to modify the GUI's existing logging > handler and to map glib style logging messages to liblogsvc style messages. > This > is trivial since liblogsvc's design is modeled around glib's logging design. > The benefits of doing it this way are: > - All error messages logged by the GUI and it's underlying GNOME stack are > captured > in the installation log without any code changes to the underlying stack. > - The GUI code, being a GNOME application, retains it's coding consistency > with > other GNOME applications and libraries. > > Thanks, > Niall > -- > This message posted from opensolaris.org > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20080317/08c678a3/attachment.html>
