Hi Joe, A couple of questions and nits:
1. Why do we need to include with libspmisvc now? 2. Is this code cstyle clean? Seems as if there is an indentation problem at line 702-706? Other parts look a bit iffy in terms of indentation and spacing. Can you verify it it cstyle clean? 3. Line 2119 isn't required in Indiana. We don't have dry run capability. Which will likely remove the need for including libspmisvc headers(mentioned in 1) 4. Normally we don't put bug id's in the comments in the code. I suppose since this is a way of fixing something temporarily it will be ok, but before we actually integrate this back in to Nevada(Or whatever we end up integrating in to) we need to remove this. thanks, sarah **** Joseph J VLcek wrote: > Please review: > > http://cr.opensolaris.org/~joev/bug534/ > > which addresses > > http://defect.opensolaris.org/bz/show_bug.cgi?id=534 > > > This is a temporary fix. A permanent fix is being worked and should be > available in a couple of months. Once that fix is available this code > will be removed. > > Thank you. > Joe > > > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > >
