Thanks Jack. I read William's suggestion too. I'll wait and see what he has to say. Thanks for the code review. ginnie
Jack Schwartz wrote: > Hi Ginnie. > > LGTM, and I think your change is the correct one. That said, William > also made a comment for a different fix. > > As I see it, setting things up in the Makefile as you have done will > give a more consistent result. What I mean is that all files being > compiled by the Makefile with the change will (consistently) have > _FILE_OFFSET_BITS set to 64. A different fix could result in some > files which don't include pyconfig.h as having _FILE_OFFSET_BITS set > differently. > > Cc'ing William in case he has a different point of view. > > Thanks, > Jack > > Virginia Wray wrote: >> Perhaps since Jack was kind enough to point out the fix, he wouldn't >> mind taking a look at my code review. >> >> Bug: http://defect.opensolaris.org/bz/show_bug.cgi?id=869 >> pyconfig.h file generates a warning in nightly build >> >> Webrev: http://cr.opensolaris.org/~ginnie/869/ >> >> Thanks, >> >> > -- Ginnie
