Joseph J VLcek wrote:
> Sanjay Nadkarni wrote:
>> I need a code review for bugs:
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=71 grub fails to
>> read /boot/grub/menu.lst
>> and
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=100 /var/crash
>> directory naming after install Indiana preview
>>
>> located at http://cr.opensolaris.org/~nadkarni/in-preview2/
>>
>> Thanks
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
>
> Minor issue #1:
> ---------------
> The -e flag to sed is not needed.
>
> -e script script is an edit command for sed. See
> USAGE below for more information on the
> format of script. If there is just one -e
> option and no -f options, the flag -e may
> be omitted.
>
>
> The wording in the bug report is different from what you implemented.
> What you have in the code seems fine. Do you need buy in from others
> on this the text change?
I have updated the bug report with the diffs. The comment right above
the change says " dumpadm -r does not work."
I will be filing a bug against Solaris for this.
>
> Possible issue #2:
> ------------------
>
> The bug repost has:
> # For zfs root, menu.lst has moved to /$rootpool/boot/grub/menu.lst.
>
> The code has:
> 444 # This file has now moved to /$rootpool/boot/grub/menu.lst.
ok.
>
> Other than that it looks good to me.
>
> Joe VLcek
