Clay Baenziger wrote:
> Hi all,
> I believe the final webrev is now available. I'm running the final
> regression tests (so please excuse the two non-collapsed in deltas in
> the webrev) however, they are available at (diff and full):
> http://cr.opensolaris.org/~clayb/delete_service/webrev3.diff
> http://cr.opensolaris.org/~clayb/delete_service/webrev3
>
> Please let me know if I failed to address anything.
>
> Thank you,
> Clay
>
Hi Clay,
The comments in installadm.c are still not quite what I had been
hoping for.
For the comments at lines 896 and 897 I was hoping for something
more like the following:
/*
* Function: do_delete_service
* Description:
* This function checks parameters, validates the
* service instance name and determines if the image
* for the service being disable should be removed,
* before calling SERVICE_DELETE_SCRIPT which handles
* the actual service deletion.
* Parameters:
* argc and argv - passed in arguments.
* handle - scfutilhandle_t * for use with scf calls
* use - usage string
* Return:
* B_TRUE - Service disabled
* B_FALSE - If there is a failure
* Scope:
(I'm not sure if this is the correct scope for this...)
* Semi-Private
*/
libaiscf_service.c
line 259 is still not cstyle compliant.
It should be (with no space after the *):
static PyObject *
AIservice_Str(PyObject *self) {
Have you run cstyle (using the -pvP options...) against the c files
you've touched?
Other than these minor nits the rest looks like it covers my previous
comments.
Thanks,
-evan
