On Fri, 2009-10-09 at 10:17 +0200, Jan Damborsky wrote:
> Hi Alex,
> 
> I have gone through the updated webrev and it looks
> almost good, I have only couple of nits to be addressed
> (please see below).
> 
> Thank you,
> Jan
> 
> td_mountall.c
> -------------
> 
> Since following functions are now unused, could you please
> completely remove them from td_mountall.c, td_util.c and td_lib.h ?
> 
> * td_umount_and_delete_swap()
> * td_unswap_all()
> * td_delete_all_swap()
> 
> 
> lines 864, 865 - comment is not correctly aligned - 'hg pbchk' reported:
> 
> $ hg pbchk
> ...
> C style check:
> lib/libtd/td_mountall.c: 864: improper block comment
> lib/libtd/td_mountall.c: 865: improper block comment close
> ...
> 
Thanks Jan,
all done, webrev's updated
-- 

::alhazred

Reply via email to