Clay Baenziger wrote:
>
> On Wed, 21 Oct 2009, Keith Mitchell wrote:
>
>> Hi,
>>
>> My notes on the webrev:
>>
>> Makefile:
>> - The changes seem to force us to edit the Makefile to compile
>> python-lxml for different versions of Python. This may or may not be
>> ok given that we want to hand this off to SFW, but it'd be cleaner if
>> we could have something akin to what IPS does, where "make 2.4" would
>> build SUNWpython24-lxml and "make 2.6" would build SUNWpython26-lxml,
>> etc.
>
> Cool way to do it! Done
>
>> - If we set PYTHON_VERS=2.4, we'll get a package named
>> SUNWpython24-lxml, but the pkginfo2.4 PKG="SUNWpython-lxml" - will
>> this be a problem?
>
> It will require the user to know to rename that directory. The
> integration dock will reject such a package (since the name has not
> been registered).
>
>> - 67-68: Why are we rm -rf'ing proto and packages in clean?
>
> In case we build a different version next time
That makes sense.
>
>> - 69: rm -rf ${PKG}
>
> Thank you
>
>> - 72: Do we need to worry about referencing different setup.py's
>> based on python version?
>
> No setup.py seems to use the version of Python it's called with as the
> hint as to which version to build for. Thus:
> PYTHON=/usr/bin/python${PYTHON_VERS}
Good to know.
>
>> pkginfo*:
>> - I'm not fully familiar with the syntax for these files, but are
>> we creating links from vendor-packages/lxml to site-packages/lxml? If
>> so, I don't think that's really necessary, since Python searches both
>> vendor-packages and site-packages when looking for modules (unless
>> I'm wrong, in which case, please correct me). Again, I don't know if
>> we want to just let SFW deal with this when we manage to pass it off
>> to them.
>
> No, we deliver only into vendor-packages. You might find the Sun
> manual Application Packaging Developer's Guide to be a handy decoder
> ring for this kind of stuff -- to ensure I'm not insane -- (section 2
> talks of the pkginfo file for example):
> http://docs.sun.com/app/docs/doc/805-6338/6j5vn5q4i?a=browse
Oh! Thanks for the link, that clarifies things.
- Keith
