Hi all,
If anyone has a few moments to review some PEP8 changes and a 20
line bug fix, I'd love to push some code before folks start pushing for
our Python 2.6 blitz. I've fixed the following UI bugs in publish-manifest
and a typo in the default A/I manifest:
4318 - publish-manifest needs to error about no criteria in non-default
manifests
4326 - Ugly error if wrong data provided in criteria manifest
11984 - Typo in suggestion in AI's default.xml manifest
To show how differential webrevs can work for PEP8 changes see the break
out of webrevs below:
Full Webrev (big):
http://cr.opensolaris.org/~clayb/publish_manifest
PEP8 Changes:
http://cr.opensolaris.org/~clayb/publish_manifest/pep8
Bug Fixes (only 21 lines!):
http://cr.opensolaris.org/~clayb/publish_manifest/diff
Bugs:
publish-manifest needs to error about no criteria in non-default
manifests:
http://defect.opensolaris.org/bz/show_bug.cgi?id=4318
Ugly error if wrong data provided in criteria manifest
http://defect.opensolaris.org/bz/show_bug.cgi?id=4326
Typo in suggestion in AI's default.xml manifest
http://defect.opensolaris.org/bz/show_bug.cgi?id=11984
