Hi Dave, thank you for review ! Please see my comments in line.
Jan Dave Miner wrote: > Jan Damborsky wrote: >> Hi, >> >> could I please ask to review easy fix for following P1 bug ? >> >> 12200 AI installs fail with wget error - libidn.so.11 required in >> microroot as of build 126 >> >> * Webrev: >> http://cr.opensolaris.org/~dambi/bug-12200 >> > > Two things which are probably separate, but since I looked... > > - OK as it is, but if we're going to start adding comments for the > specifics behind files listed here, please drop a bug to get that > completed (overall, I'd like to see this organized in some logical > fashion - right now I can't discern why things are listed in the order > they are). It seems that the initial intent was to have those files sorted alphabetically, but since not explicitly expressed in the manifests, the idea was likely abandoned at some point. I agree that it might be better to have this organized in different way, so that relationships and dependencies are more evident. Then when some feature is to be removed, it would be easier to identify related pieces which can be removed as well. I will file bug for this. > > - The libcrypto/libssl items in the subsequent lines aren't needed any > longer, they were moved into /lib in build 104. If we aren't getting > errors about things like this out of the boot archive construction > process, then we need to be; if we are and just aren't noticing > (either it's going to the detailed log and we aren't looking, or > something else), then that needs to be dealt with, too. I have taken a look at DC log files (simple as well as detailed) and haven't seen any complaints about non-existing pieces when boot archive was being constructed. I will also file bug for this.
