Hi William,
William Schumann wrote: > Jan, > I'm taking your advice on all points, except the one noted: > > Jan Damborsky wrote: > ... >>>> >>>> >>>> disk_part.c >>>> ----------- >>>> >>>> ... >>>> 34 #ifdef __sparc >>>> 35 #define fdisk_is_dos_extended(p) (B_FALSE) >>>> 36 #else >>>> 37 #include <libfdisk.h> >>>> 38 #endif >>>> ... >>>> >>>> Do we need fdisk_is_dos_extended() at all ? Could we instead use >>>> check for (TD_PART_ATTR_PART_TYPE == TD_PART_ATTR_PART_TYPE_EXT) ? > Looking at the code again, I see that it is needed in several places. > To create an extended partition, the user specifies an fdisk extended > partition ID in the manifest, AI calls om_create_partition(), passing > the requested ID. TD info is not available for partitions being > created. fdisk_is_dos_extended() is a standard way of checking by ID > whether or not a partition is extended. ok - thank you for clarifying this. Based on this, I am fine with the original solution. Thank you, Jan
