On ??, 2009-10-26 at 10:25 +0100, Jan Damborsky wrote:
> Hi Alex,
>
> the fix looks good with respect to the overall approach taken
> and the chosen scope at this point, I have only couple of
> comments/nits related to the implementation - please see below.
>
> Also, could you please updated bug with this information
> (chosen solution and scope) and put it into at least
> FIXUNDERSTOOD state ?
Done
>
> Thank you,
> Jan
>
>
> ti_api.h
> --------
> 77 - this new milestone should not be added - it is only used
> in scenario where TI target is determined implicitly
> (TI_ATTR_TARGET_TYPE attribute is not specified) which
> is not the case here - TI_ATTR_TARGET_TYPE has to be set
> to TI_TARGET_TYPE_DISK_LABEL.
Fixed
> ti_dm.c
> -------
>
> nit:
> 1479 * Obtain disk name. It can be provided by
> TI_ATTR_LABEL_DISK_NAME
> ->
> 1479 * Obtain disk name. It is provided by TI_ATTR_LABEL_DISK_NAME
Fixed
>
> ...
> 1504 if (errno == ENOTSUP) {
> 1505
> 1506 /* EFI label */
> ...
> Just checking - is this check reliable ?
These lines from devinfo
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/cmd/devinfo/devinfo.c
Yes, it works:
Disk c0t3d0 was labeled as EFI before:
<TIMM_I Oct 21 06:08:43> Target type to be created: DISK_LABEL
<TIDM_I Oct 21 06:08:43> Disk c0t3d0 has an EFI label
<TIDM_I Oct 21 06:08:43> format: Creating SMI label for c0t3d0
<TIDM_I Oct 21 06:08:43> dm cmd: printf 'label
...
>
> 1521-1524 - since we know at this point disk already has SMI label,
> should we proceed with 'format' or could we just return
> with success ?
>
>
>
Fixed and retested, webrev's updated.
Thank you very much, Jan!
--
::alhazred
