Hi Sue,
Susan Sohn wrote: > Hi Jan, > > auto_install.c > 711, 716, 718 (and all others in new code) Should these auto_log_print > messages be gettext'd? I noticed that most (though not all) of the > others are. Should they all be? You are right that currently it is mix of localized and not localized messages. I will add gettext() to all auto_log_print() calls in auto_install.c to make it consistent. > 1760 "now when it is complete" -> "now that it is complete" I will change this. > > installation-screen.c > 677,707 just curious what the reason was to add the curly braces Those curly braces were added to create 'block' - this allowed me to declare local variable 'install_error' which is used only within that block. > > live-fs-root > 396 "from server" -> "from install server" I will change this. > 411, 414, 428, 432 Need continuation character You are right - thank you for catching this ! > 384,400, 432 "reachable from" -> "reachable from the" I will change this. > Not really in your changes, but might it be better to define > solaris.zlib and solarismisc.zlib up at the top and use variables > throughout? I will do this. > > perform_slim_install > 240 add nvlist_free for success case Agreed - it will be added. Thank you very much for code review ! Jan
