Sundar, Thanks for the review. Comments are inline.
Jean Sundar Yamunachari wrote: > Jean McCormack wrote: >> Dave Miner wrote: >>> Jean McCormack wrote: >>>> I have posted the functional specification for the Install support >>>> for extended partitions and slice modification at: >>>> >>>> http://www.opensolaris.org/os/project/caiman/Extended_Partition_Support/EP_Func_Spec.txt/ >>>> >>>> >>>> >>> >>> I presume that should be EP_Func_Spec.odt? >>> >>> Dave >> It is now. I replaced it this morning with the .odt. >> >> Jean >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > Jean, > > General: minor nit: section numbers are not consistent through out the > document I'll check that. > > 1.1 Scope of the problem > > - Are you planning to change libti (which does the actual partition > and slice modification work)? or the changes will be in liborchestrator? liborchestrator > - You mentioned GUI support is part of the scope. Is GUI changes part > of this project? That is being done by the xdesign group so I didn't call it out as changes. > > 1.2 Interdependencies > - AI also depends on the changes to TD, TI and Orchestrator Good catch. > > 2.1 Major components > - Will there be any changes in libti? Right now we think not. > > > 2.3 Test Environments > - If there are no changes made by this project to AI, what kinds of > tests will be performed with AI? Is it regression testing to make sure > that existing things still work? This project is not making changes to AI. But we should test AI. It's now listed. > > 3 User interface > - I don't understand the terminology. Is it logical disks or logical > partitions? I missed these references to logical disks. I've changed them to logical partitions. In the literature that I've read it seems to vary how they are referenced. I've seen logical disks, logical volumes and logical partitions all referring to the same thing. Consistency within the document is probably the most important thing. > > 1.1 libdiskmgt support > - AI uses FD_NUMPART in couple of places. As longs as FD_NUMPART is > updated to correctly, we should be ok. > What the extended partition work (not ours but the stuff checked in) did was leave FD_NUMPART at 4 and MAX_EXT_PARTS extends that. AI will need to make modifications to support this. That should be part of the AI completeness project. > > 1.2 Scenario Two > - Which module creates the logical partition? Is it Orchestrator or libti? liborchestrator sets up the appropriate attributes to do so and then calls libti which executes the fdisk command. > > > - Sundar >
