Shawn Walker wrote:
> Jack Schwartz wrote:
>> On 07/30/09 14:32, Shawn Walker wrote:
>>> Dave Miner wrote:
>>>> Shawn Walker wrote:
>>>>> Jack Schwartz wrote:
>>>>>> Hi Shawn.
>>>>>>
>>>>>> On 07/30/09 11:19, Shawn Walker wrote:
>>>>>>> Dave Miner wrote:
>>>>>>>> Shawn Walker wrote:
>>>>>>>>> SVR4 package support is fairly minimal at the moment, and is 
>>>>>>>>> deprecated or obsolete (not sure of the 'official' 
>>>>>>>>> terminology).  Why even support it at this point?
>>>>>>>>>
>>>>>>>>
>>>>>>>> Because that's the format some drivers are available in.  Yes, 
>>>>>>>> we have all sorts of ISV/IHV engineering teams fired up to get 
>>>>>>>> them converted to IPS, but I'm favoring adoption over purity.
>>>>>> Yes, it will be easier for users to get started with OpenSolaris 
>>>>>> if their rare controller card's driver can be loaded without them 
>>>>>> having to find an IPS-packaged version of it.
>>>>>>
>>>>>> If their package behaves and has only new files and doesn't 
>>>>>> overwrite system files, I believe there should be no problems.
>>>>>>>
>>>>>>> I figured as much, but it isn't a panacea.  Is there going to be 
>>>>>>> an escape hatch for users stuck with broken SVR4 packages?
>>>>>> We can check each file in the package being added, and display a 
>>>>>> warning if that file already exists on the system.  Does this 
>>>>>> sound reasonable?
>>>>>
>>>>> That would assuage my fears greatly.  There's really no protection 
>>>>> in place to keep SVR4 packages from butchering files already on the 
>>>>> system.
>>>>>
>>>>
>>>> SVR4 pkgadd will already tell you that the files are installed and 
>>>> let you choose to continue.  Don't write code to replicate that.
>>>
>>> According to the pkgadd code:
>>>
>>>     109     /*
>>>     110      * check to see if we can guess (via Rlist) what
>>>     111      * pathnames this package is likely to install;
>>>     112      * if we can, check these against the 'contents'
>>>     113      * file and warn the administrator that these
>>>     114      * pathnames might be modified in some manner
>>>     115      */
>>>
>>> ...it only checks against the contents file, so these SVR4 packages 
>>> could overwrite files in IPS packages without the user knowing, 
>>> correct?  Or is the pkgadd code comment wrong?
>> I did a pkg install of SUNWcs in a test area, verified there was no 
>> var/sadm/install/contents file, and then started a pkgadd of SUNWcsr 
>> from onnv.  3 pages of conflicting files streamed by.  So it appears 
>> pkgadd does the right thing and doesn't use the contents file.
> 
> Thank you.  Should someone update the pkgadd comment then?
> 

Feel free to drop a bug in bugster.

Dave


Reply via email to