Hi Evan, On Fri, 31 Jul 2009, Evan Layton wrote:
> This look pretty good, just some minor comments and questions... > > In section 3.1 it states that the user will be presented with > these three choices from the grub menu: > * Boot from media and invoke AI with a specified manifest > * Boot from media and invoke AI with a default manifest > * Boot from hard disk > > It then states that the first one will be the default. If this is > the case then the user is expected to provide a location for a > manifest in the default choice. Doesn't it make more sense to have > the second choice with the default manifest as the default choice > in the grub menu? The problem with having the second choice as the default is - if a user inserts this bootable media into a cd/dvd drive and then walks away for some reason, we end up maliciously overwriting his disk. > 3.1.1 maybe it should be stated here that better progress > observability is outside the scope of this project? Sure I can state that. > 3.3 The second paragraph is a bit awkward. > maybe something more like: > Since this project aims to add more functionality to this service, > it will endeavor to split up the live-fs-root service into two > disparate services where each service's behavior is based on the > type of install media (network or cdrom/dvd/usb) being used. > > 3.4 second paragraph > These two functional pieces will - one... Rephrased both these sections. > Also if we're doing a CD based install here do we want to installer > to eject the CD in addition to shuting down the system so that on > reboot it doesn't default to going back into the installer? The ability to eject a mounted CD is currently an RFE - http://defect.opensolaris.org/bz/show_bug.cgi?id=1115 The choice of (grub) defaults should prevent the system from going back to installer post-reboot. Thanks for the feedback! Alok
