Evan Layton wrote: > Hi Jean, > > The changes look fine to me as well. > > I agree with Joe that we should probably create a new bug to cover > Dave's second comment in 5851. That being the addition to DC to check > the ISA and exit if the machine we're running on can't build for that > ISA. I'll open an RFE to cover the addition of an ISA parameter to the manifests.
Thanks to both of you for the code review. Jean > > Thanks, > -evan > > Joseph J VLcek wrote: >> These changes look fine to me. >> >> I see you have updated bug 5851 to state you are making the manifests >> with ISA specific names and plan to address putting this info into >> the manifest as an open issue. >> >> Maybe a new bug should be open for that. What do you think? >> >> Joe >> >> >> Jean McCormack wrote: >>> Please review the fix for bugs >>> >>> 5824 ai_sparc_image.xml is not being delivered by SUNWdistro-const >>> package >>> 5851 DC should have ISA specific manifests names when appropriate. >>> >>> >>> >>> CR: http://defect.opensolaris.org/bz/show_bug.cgi?id=5824 >>> and http://defect.opensolaris.org/bz/show_bug.cgi?id=5851 >>> >>> Webrev: http://cr.opensolaris.org/~jeanm/slim_5824/ >>> >>> >>> Jean >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
