Hi Jason,

Jason Zhao wrote:
> Hi, Jan,
>
> Thank you for your answer, please see comments in line.
> jan damborsky wrote:
>> Hi Jason,
>>
>>
>> Jason Zhao wrote:
>>  
>>> Hi, Jan and William,
>>>
>>> Some questions here, very appreciate if you can answer them.
>>> 1. Does EFI label slice include "*flag*" and "*tag*"? Because libtd
>>> shows nothing about these 2 attributes after I modify the slice
>>> table. However, prtvtoc command could print the tag and flags out.
>>> Is this a bug?
>>>     
>>
>> Thank you for pointing this out.
>> Looking at the libdiskmgt specification, it is not a bug,
>> but expected behavior:
>>
>> [...]
>>
>>  * For slice descriptors the attributes are:
>>  *    index:        uint32
>>  *    devt:        uint64
>>  *    start (block):    uint64
>>  *    size (blocks):    uint64
>>  *
>>  *    optional attributes
>>  *      only on slices that have a device ID
>>  *        deviceid:     string
>>  *      only on slices on media with a VTOC label
>>  *        tag:          uint32
>>  *        flag:         uint32
>>  *      only on slices on media with an EFI label
>>  *        name:        string
>>  *        efi           boolean
>>  *      only on slices that are mounted
>>  *        mountpoint:    string
>>  *      only on slices that are on drives shared in a cluster
>>  *        localname:    string
>> [...]
>>
>> Full specification can be obtained here (available only internally):
>> http://sac.sfbay.sun.com/Archives/CaseLog/arc/LSARC/2004/743/spec.txt
>>
>> Since at time of being, EFI labeled disk are not supported as target
>> for the installation, we haven't evaluated yet if this limitation
>> needs to be addressed.
>>
>> This is something we will need to take into account once installation
>> on EFI labeled disks becomes requirement.
>>
>>   
> OK, it looks like libtd does not support EFI label now. Then,
> how about we will not test EFI label disk test cases now and
> if libtd will support it in the future, we will add related cases
> in test suite.

libtd can recognize EFI labeled disks - this feature is supported.
If disks contains EFI label, test_td reports 'G' in label column for
such disk.
I might recommend to continue to test, if libtd correctly recognizes
EFI label and probably skip other test cases related to EFI for now.

Thank you,
Jan


Reply via email to