Sundar Yamunachari wrote:
> Ethan,
> Thanks for the review.
>
> Ethan Quach wrote:
>> Sundar,
>>
>> auto-installer
>>
>> 86 - comment says ${IMAGE}/install.conf, but you use the file
>> /tmp/install.conf I don't see see $IMAGE defined anywhere, and
>> I doubt it equals /tmp
> The file is stored as part of the image when the service or client is
> configured. live-fs-root downloads this file and saves it in /tmp. I
> will add a comment to indicate that the file is downloaded and saved in
> /tmp.
I still have a nit with the usage of $IMAGE; this makes it seem like
its a variable somewhere in a script, but its not. Could you rephrase
it to not use $IMAGE?
"...defined in the install.conf file, which was downloaded and saved
in /tmp."
>>
>> 89 - is 'service' the full name of the KEY you're looking for?
>> If the format of the file is known, i.e. no whitespace, grepping
>> for '^KEY=' would be better.
> . The file format is "key=value\n". I will use ^key. Based on installadm
> changes made for 4194, the key will be changed to 'install_service' from
> 'service'. The webrev is updated with these changes.
okay
thanks,
-ethan
>
> Thanks,
> Sundar
>>
>>
>> -ethan
>>
>>
>> Sundar Yamunachari wrote:
>>> Hi,
>>>
>>> Please review the following fix.
>>>
>>> 6012 Changes needed in live-fs-root and auto-installer methods for
>>> SPARC AI
>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=6012
>>>
>>> The webrev is at: http://cr.opensolaris.org/~ysundar/6012
>>>
>>> Thanks,
>>> Sundar
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
