Jean McCormack wrote: > Karen Tung wrote: > >> Hi Jean, >> >> Why is the link to the webrev only internal? Please post to the >> cr.opensolaris.org in >> case people outside of side want to review. >> > Because I sent the wrong one. It's the same webrev just before I copied > it to cr.opensolaris.org > Here's the link: > http://cr.opensolaris.org/~jeanm/slim_4729/ > >> Here are my comments: >> >> create_iso, line 97: The $DIST_ISO there also needs double quote >> > Tested and appears this isn't true. Here's the output: > /usr/share/distro_const/create_iso: mkisofs of /rpool/dc/jean/media/Open > Solaris AI.iso failed > > >> create_usb, line 83: $DIST_ISO needs double quote >> create_usb, line 99: $DIST_USB needs double quote. >> > These should be OK for the same reason. > > Jean > > Hi Jean,
Thanks for testing that. I guess the double quote are not needed for those lines because we are doing a print, and not passing the value into a command. Personally, I think that having the double quote there makes it look more consistent over the entire script, but I will leave it up to you to put it in or not. Thanks, --Karen
