jan damborsky wrote: > Hi Dave, > > looking at the changes, I can see that install-lan&keyboard-layout > are removed from appropriate packages, but they will remain > in slim_source gate. > > I think since they are no longer in use, we could remove also > appropriate source codes from the gate - however, in that case > usr/src/gui-install/src/Makefile would need to be accommodated > as well. > > I am not sure if those changes might fall into the bug you > are fixing - if you think they are out of the scope of this fix, > could you please file separate bug for removing install-lan > and keyboard-layout from slim_source gate ? >
Thanks for reviewing thoroughly, as you note that webrev wasn't complete. I've pushed the right one, if you'd please re-review ;-) Dave > Other than that, the suggested changes look good to me. > > Thank you, > Jan > > > Dave Miner wrote: >> Please review the fix for >> >> 5831 install-lan&keyboard-layout no longer in use - should be removed >> from slim_source gate and livecd >> http://defect.opensolaris.org/bz/show_bug.cgi?id=5831 >> >> Webrev is at >> >> http://cr.opensolaris.org/~dminer/slim_5831/ >> >> Dave >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
