Glenn Lagasse wrote: > Hey Evan, > > * Evan Layton (Evan.Layton at Sun.COM) wrote: >> I need to get a code review for the following simple fix: >> >> 5221 Improper message when creating a BE if no grub/menu.lst file >> http://defect.opensolaris.org/bz/show_bug.cgi?id=5221 >> >> Webrev: >> http://cr.opensolaris.org/~evanl/5221/ > > libbe.h: > > 127: extraneous , at the end of BE_ERR_NO_MENU
fixed > > be_utils.c: > > 607: you set ret equal to BE_ERR_NO_MENU on line 606 but then that's > clobbered by line 607. > > 1094: same comment as 607 yes those were meant to have been inside an else. Fixed. (d'oh...) The webrev has been updated. Thanks! -evan > > Glenn > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
