Hi Dave, thanks a lot for reviewing those changes. Please see my comments in-line.
Jan Dave Miner wrote: > jan damborsky wrote: >> Hi William, >> >> thank you very much for review. >> I have incorporated all changes you suggest. >> Could you please take a look at new webrev ? >> >> http://cr.opensolaris.org/~dambi/bug-5284 >> > > pkginfo.tmpl: NAME and DESC aren't quite right, as this isn't the test > suite, but only the test driver programs. You are right. I have changed NAME and DESC, so that they mention 'test driver' instead of 'test suite'. > > prototype_com (and Targetdirs, Makefile.master, lib/Makefile.targ): So > long as you need to change the above, I'd just put these in > /opt/install-test/bin, not sbin. Done. Could you please take a look at updated the webrev (it is at the same location) ? Thanks again, Jan
