Passwords should be encrypted in manifests, not by the installer code. The basic fix was simple - remove encryption calls from the code - but it was noted that there could be XML entities encoded in the password, so XML entities will now be decoded. The XML decoding is basic and has some shortcuts, such as decoding only 1-byte numeric values. It is expected that the AI manifests will soon be restructured and then should be parsed with established parsers, such as in libxml2.
Bugs fixed along the way: - values with spaces were being truncated at the first space - apostrophes used as value delimiters were not working - some typos with keyword name not matching intended storage variable name http://defect.opensolaris.org/bz/show_bug.cgi?id=4246 http://cr.opensolaris.org/~wmsch/bug-4246/
