I noticed that you hardcode this to DUMPADM_ENABLE=yes. Did you consider making that a parameter into the method? That way if in the future there is a need for no it would be easy to call this method. If you decide not to do this, then I personally think a better name for the method would be enable_dumpadm. update_dumpadm implies more flexibility.
Jean Joseph J VLcek wrote: > * Please review changes for Bug 5003: > > http://defect.opensolaris.org/bz/show_bug.cgi?id=5003 > > * webrev > > http://cr.opensolaris.org/~joev/bug5003_JAN_2009/ > > * The modules affected and tested: > > ICT - Python code including install-finish > > --- Testing --- > > * Testing done with GUI on x86: > ------------------------------- > > [1] Booted LiveCD image on live hardware HP Pavilion dv5000 > [2] mount -F lofs to use the updated ict.py module > [3] copied update install-finish to /sbin > [3] Installer run > > * Results: > All ICT completed successfully and system booted, /etc/dumpadm.conf is > updated and dumpadm reports: "Savecore enabled: yes" > > > * Testing done on SPARC: > ------------------------ > None. This ICT is not invoked on SPARC > > > * Testing done with AI on x86: > ------------------------------ > None. This ICT is not invoked for AI > > > * Description: > > This code change is to set the DUMPADM_ENABLE=yes in /etc/dumpadm.conf > > Thank you. > Joe > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
