Evan Layton wrote:
> Hi Ethan,
>
> one minor nit:
> The comment on line 246 "have a zone root container dataset underneath it."
> might make more sense with something like:
> "have a zone root container dataset underneath the zonepath dataset."
That doesn't really make sense to me given we're already stating
"zonepath dataset" in the beginning part of the sentence. Would
it be more clear if I just bullet out the constraints ...
The zonepath dataset must:
- not be under any global BE root dataset.
- have a zone root container dataset underneath it.
thanks,
-ethan
>
> Other than that it looks good to me.
>
> Thanks for fixing this!
>
> -evan
>
> Ethan Quach wrote:
>> Need a review ...
>>
>> Defect:
>> ----------
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4794
>>
>> Webrev:
>> ------------
>> http://cr.opensolaris.org/~equach/webrev.4794
>>
>>
>> I've reproduced the bug case and tested that these
>> changes fix the issue. A user can now create a new
>> boot environment while an unsupported ipkg zone
>> exists on the system. The unsupported zone is properly
>> skipped.
>>
>> The changes also fixes other functional cases that
>> also fail when there are unsupported zones in the
>> boot environment, such as mounting/unmounting
>> and destroying a boot environment with an unsupported
>> zone.
>>
>>
>> thanks,
>> -ethan
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
