Jan, Looks good.
Sue jan damborsky wrote: > Hi Sue, > > Susan Sohn wrote: >> Hi Jan, >> >> Just remove the now empty comment on lines 1616-1618 and you're all >> set. ;) > > Done :-) > I have updated the webrev. > > Thanks for catching this ! > Jan > >> >> Sue >> >> jan damborsky wrote: >>> Hi Sue, >>> >>> thank you very much for the review. >>> >>> I have combined the comments according to your >>> suggestion and the result is much more better than >>> original version. >>> Could you please take a look at updated webrev >>> and let me know if the changes look better ? >>> >>> Thank you, >>> Jan >>> >>> >>> Susan Sohn wrote: >>>> Hi Jan, >>>> >>>> Just a comment on the comments in perform_slim_install. >>>> >>>> I would recommend combining together the two block comments for >>>> om_get_min_size. Perhaps take the "For Slim installer" paragraph and >>>> append to the "Get uncompressed size" line on 1592. And then take >>>> the "In case of Automated Installation" paragraph and append to "If >>>> information about image size" line (1603): >>>> This is the case for Automated Installation, as the size needs to be >>>> be dynamically calculated.... >>>> >>>> Otherwise, looks good. >>>> Sue >>>> >>>> jan damborsky wrote: >>>>> Hi, >>>>> >>>>> could I please ask for reviewing the fix >>>>> for following bug ? >>>>> >>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4280 >>>>> >>>>> The webrev is available at: >>>>> http://cr.opensolaris.org/~dambi/bug-4280 >>>>> >>>>> Thank you, >>>>> Jan >>>>> >>>>> >>>>> Modules affected: >>>>> ----------------- >>>>> * liborchestrator >>>>> >>>>> Testing done: >>>>> ------------- >>>>> configuration: >>>>> >>>>> regression tests: >>>>> * HW: vmware guest (1GB RWM) on Linux host >>>>> * SW: LiveCD installation based on osol-0811-rc2.iso >>>>> >>>>> test of the fix: >>>>> * HW: >>>>> * AI server: Lenovo X61 running 2008.11 >>>>> * AI client: Ultra 20 (1GB RWM) >>>>> * SW >>>>> AI image based on 101b containing liborchestrator >>>>> with fix created by Distro Contructor >>>>> >>>>> [1] Without fix >>>>> --------------- >>>>> * Following messages reported in AI install_log >>>>> ... >>>>> <OM_W Mar 18 08:53:38> Couldn't open image info file >>>>> /.cdrom/.image_info >>>>> <OM Mar 18 08:53:38> Couldn't read image info file >>>>> ... >>>>> >>>>> [2] With fix >>>>> ------------ >>>>> * messages in question didn't appear in AI install_log >>>>> >>>>> [3] regression test >>>>> ------------------- >>>>> * LiveCD booted >>>>> * installer tried with liborchestrator containing the fix >>>>> * on Disk screen minimum and recommended disk size were >>>>> reported correctly (they are calculated from the info >>>>> read from /.cdrom/.image_info file) >>>>> >>>>> >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> caiman-discuss at opensolaris.org >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
