Hi Niall, Thanks for the view. The prototype is there but I missed timezone.h in the file list to generate the webrev.
Regards, Jedy On Wed, 2008-12-17 at 11:33 +0000, Niall Power wrote: > Hi Jedy, > > There is no declaration in timezone.h for: > > +void > +timezone_set_default_focus(Timezone *timezone) > > which is referenced in datetimezone-screen.c > > I believe this will cause a compiler warning. > > Otherwise, looks good. > > Thanks, > Niall > > > > > > > Jedy Wang wrote: > > Patch updated. Now the default widget with focus is the 1st label. I > > also included fixes for 5854 because it's very simple. Just a string > > change. You can find the updated webrev at > > http://cr.opensolaris.org/~jedy/3796-5854/ > > > > Frank, do you know which l10n engineer should I contact for translation > > work of the installer? > > > > Regards, > > > > Jedy > > On Tue, 2008-12-16 at 05:59 -0800, Frank Ludolph wrote: > > > >> Jedy Wang wrote: > >> > >>> Hi all, > >>> > >>> You can find the bug report of 3796 - Focus remaining on the "Next" > >>> button rather than going to the first thing in the panel that appears > >>> after you press "Next" at > >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3796 > >>> and webrev at > >>> http://cr.opensolaris.org/~jedy/3796/ > >>> > >>> The fix add a *_screen_set_default_focus functions for every necessary > >>> screen and call them at the right places. The function will set the > >>> default widget with focus for the screen: > >>> welcome screen: release notes button > >>> installation disk screen: 1st disk button > >>> date timezone screen: region combo box > >>> language screen: default language in the tree view > >>> users screen: 1st text entry (This had been done before) > >>> confirmation screen: install button > >>> > >>> > >> The install button should not have default anything. Because it is a > >> destructive action the user should not be able to accdentally invoke it. > >> It should be invokable only by a mouse click or by explicitly using the > >> keyboard to move the focus to the button (tabbing) and then invoking. > >> > >> Frank > >> > >>> Regards, > >>> > >>> Jedy > >>> > >>> > >>> > >> _______________________________________________ > >> caiman-discuss mailing list > >> caiman-discuss at opensolaris.org > >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > >> > > > > >
