On 01/ 6/10 06:47 PM, John Fischer wrote:
> Dave,
>
> Should the order of this trap be changed?
>
> + trap "{ rm -f $fdi; umount -f $mnt; rmdir $mnt; }" SIGTERM EXIT
>
> Should it be unmount, rmdir and then rm -f $fdi since
> the fdi file prevents HAL from doing its magic?
>It doesn't actually matter, because HAL's attempt to mount (if it managed to act within this tiny window) would necessarily fail since the slice is already mounted, but I agree that it's worth re-ordering so that, were this to happen, it doesn't get the chance to pop up one of those annoying "Unable to mount volume" messages that doesn't tell you what volume or why. Dave > Otherwise, it looks good. > > John > > > On 01/ 6/10 03:32 PM, Dave Miner wrote: >> I'd appreciate reviewers for the webrev at >> >> http://cr.opensolaris.org/~dminer/slim_11654/ >> >> which addresses >> >> 3446 usbcopy cannot work with localized message command. >> 5018 usbcopy needs signal handler >> 11654 usbcopy fails to copy osol_124 usb to usb flash device due to >> problem with hal >> >> Thanks, >> Dave >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
