Matt, thanks for looking at this.

On 01/18/10 02:02 PM, Matt Keenan wrote:
> Code looks fine,
> 
> Couple of comments nits really :
> 
> - I'd recommend running "hg nits" on your changed files to ensure you are not
>    introducing any new issues, from just reading the changes your multiline
>    comments will throw new warnings.

Done.

> 
> - Update the copyright year to 2010

Done.

> 
> Other than that looks fine to me.

Newer webrev uploaded...

Thanks,

Darren.

> 
> cheers
> 
> Matt
> 
> Darren Kenny wrote:
>> Hi,
>>
>> Could I please get some review of the fix for defect:
>>
>>      13862 -  Pre-existing logical partition slow to be marked with warning
>>
>> The webrev can be found at:
>>
>>      http://cr.opensolaris.org/~dkenny/fix.13862.slim/
>>
>> Thanks,
>>
>> Darren.
>>
>> [1]- http://defect.opensolaris.org/bz/show_bug.cgi?id=13862
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
> 

Reply via email to