On 01/19/10 06:37 PM, Alok Aggarwal wrote: > Hi Keith, > > On Tue, 19 Jan 2010, Keith Mitchell wrote: > >> transfer_mod.py: I'm wondering why you chose to use a "break" statement >> instead of updating either line 934 or line 941 such that they're both either >> using "retry_timeout> 0" (or both using ">= 0"). > > Neither of those work (I've tried them). > > If you start out with retry_timeout being '0' > changing to "retry_timeout>= 0" doesn't work because > you end up doing a retry when you shouldn't. And, you end > up setting retry_timeout to a negative number as well > which results in an infinite loop. > > Also if you use "retry_timeout> 0", then you don't > execute the command even once if retry_timeout starts > out being '0'. > > So, "break" seemed like the most straightforward > and one that worked in my testing as well. > >> Additionally, if, after the timeout gets to 0 we haven't successfully >> executed this block, I think we'll want to explicitly raise a TAbort with a >> reasonable message. > > I'm not sure I understand, can you rephrase that? > >> media-fs-root: It seems like we could leave the "sshd -c" and "svcadm enable" >> as common code, and then simply check the variable again and perform the >> set_lang/kbd commands in the liveCD case. (I just noticed that sshd -c is not >> run for liveCD - I didn't realize you could ssh in without running this >> command? Or does some magic happen elsewhere that makes it work?) > > I'm merely reverting this code to what it used to be > a couple of months back. > > The keys are not generated for the Live CD case for some > reason. It could have something to do with making the Live CD > vulnerable to attacks if you do this (since it's built with > a known root password). OTOH, I don't see how ssh can be used > without generating keys. > > Which leads me to question whether QE is even using this > feature any more? AFAIK, the "enable ssh" feature was > requested primarily by QE. >
If you look at the start method for ssh (/lib/svc/method/sshd) you'll see why it doesn't need to be done on the live CD. Dave
