Karen Tung wrote: > On 01/19/10 14:09, Joseph J VLcek wrote: >> Please review the fixes for: >> >> Bug 13488 : LiveCD changes required for new GDM >> http://defect.opensolaris.org/bz/show_bug.cgi?id=13488 >> >> The webrev is here: >> http://cr.opensolaris.org/~joev/bug13488/ >> >> >> Testing: >> ----------- >> >> This bug is specific to the LiveCD. I have built a LiveCD images and >> tested by booting to the LiveCD desktop, which comes up without the >> login prompt. Then after performing an installation and rebooting to >> the installed disk the specified username/password is prompted for. >> >> Thank you! >> >> Joe >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > Hi Joe, > > The changes look good to me. However, I think it would be better if > we define a variable for the location of the gdm directory, and then, > have all the code use it. That way, next time when they move the gdm > directory, we just need to change this one variable instead of changing > so many lines. > > Thanks, > > --Karen > Hi Karen,
I don't expect that the location of the gdm directory will change frequently. Also we have file locations interspersed throughout the code. Perhaps this should be addressed as an RFE across our code. Joe
