On 01/19/10 08:14 AM, Jan Damborsky wrote:
> Hi,
>
> could I please ask two pair of eyes to take a look at
> fix for following bug:
>
> 13393 min_mem64=1536 in AI GRUB menu should be revisited
>
> webrev:
> http://cr.opensolaris.org/~dambi/bug-13393/
>

grub_setup.py:

136: seems to me the value should come from something in the manifest 
rather than being hard-coded.

140-151: couldn't you simplify by using a with statement instead?

Dave

Reply via email to