Hi Jan,
On Wed, 20 Jan 2010, Jan Damborsky wrote:
> Hi Alok,
>
> please see my comments below.
>
> Thank you,
> Jan
>
>
> auto_installer
> --------------
>
> 89 AI_DEBUG_MODE=`$GREP "^install_debug" \
>
>
> 'GREP' is not defined in the script, so I assume it
> would not work (for Sparc).
Yep, this is the first thing I hit when I started
testing sparc. Changed.
> media-fs-root
> -------------
> 196 livessh=`$PRTCONF -v|$SED -n '/livessh/{;n;p;}'|$CUT -f 2 -d\'`
>
> Just curious (I haven't tried), does it work for Sparc bootable AI
> as well ?
There isn't a way to enable ssh in the sparc bootable AI
media. There does not seem to be a requirement (test or
otherwise) to enable ssh on the sparc bootablle AI media.
> transfer_mod.py
> ---------------
>
> Why only '1' (not other error codes) returned
> from pkg image-create triggers retry ?
A retry needs to be done only for the case where the
network has not been configured. pkg(1) does not have
a specific error code for such a failure. An error code
of '1' is used to convery such a failure (among other
sorts of errors).
> It seems that is the case where C 'for' loop
> would take care of this in elegant way - e.g.
>
> for (status = 1; status == 1&& retry_timeout>= 0; retry_timeout -= 10)
> ...
>
> Then we could inspect 'status' once the loop finishes.
>
> Not sure about how to accomplish this in elegant way
> in Python.
I'm not sure how craft up a similar thing in python.
Thanks for the review!
Alok
