Dave Miner wrote: > On 01/15/10 02:23 PM, Joseph J. VLcek wrote: >> Please review the fixes for: >> >> Bug 6103 : ICT - may not be setting file permission correctly on some >> files >> http://defect.opensolaris.org/bz/show_bug.cgi?id=6103 >> >> and >> >> Bug 8580 : Add contrib repo to the default list of repositories >> http://defect.opensolaris.org/bz/show_bug.cgi?id=8580 >> >> >> >> The webrev is here: >> http://cr.opensolaris.org/~joev/bug6103_8580/ >> > > Just one issue, with default.xml. I don't think this change should > happen, because I believe that the result will be that if a manifest > doesn't provide additional publishers, the contrib repo will always be > added. If so, that's probably not what authors of specific manifests > would expect. > > Dave
Per a discussion offline with Dave Miner he feels the fix I propose is fine as-is. Joe
