Matt, Under the assumption that you will make Darren's change everything else looks good.
John On 01/25/10 07:07 AM, Darren Kenny wrote: > With the webrev at: > > http://cr.opensolaris.org/~mattman/bug-2822/ > > All looks good. > > Minor nit: > > 5903 if (warningsecondarytext) > 5904 g_free(warningsecondarytext); > > The if() isn't really needed since g_free() tends to check for NULL > first anyway. > > Darren. > > > > On 01/25/10 02:37 PM, Matt Keenan wrote: >> Looking for two pairs of eyes to review the following : >> >> 2822 GUI should display warning message, if disk/partition size is less >> than >> recommended >> http://defect.opensolaris.org/bz/show_bug.cgi?id=2822 >> >> Webrev : >> http://defect.opensolaris.org/bz/show_bug.cgi?id=2822 >> >> >> Provide two missing warnings as specifed in UI Spec, where disk or partition >> size is greater or equal to minumum size and less then the recommended size. >> >> >> Cheers >> >> Matt >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
