On 01/26/10 17:34, Alok Aggarwal wrote:
>
> On Tue, 26 Jan 2010, Ethan Quach wrote:
>
>
>>> dc_defs.py: Why bother setting the do_safe_default keyword in
>>> DC and propagate it via the .image_info file? Why not just
>>> always create a safe default GRUB menu entry especially since
>>> we don't provide a user visible way to tweak DC to not be
>>> the case?
>>
>> So that there's still that separation from what decides when to do it.
>> For example, if we want an 2010.03 Ai server to properly support
>> 2009.06 Ai images we need to do it this way -- embed the decision in
>> the image. The same reasoning going forward if future images decide
>> to change things in some way I guess.
>
> I think that may work for the immediate case but longer
> term this sounds like an ad-hoc solution from an extensibility
> point of view. The issue of maintaining multiple image versions
> on the AI server is a generic one, I'm not sure if solving it
> by embedding tags into the image_info file is the correct approach.

Agreed.  Longer term we need something more stable.

>
>> On the DC end of things, I wasn't sure I'd wanted to make it a tunable
>> or if it should be a tunable just to make the impl cleaner, and not
>> reliant
>> on the build# of the build system. Thoughts?
>
> I'm ambivalent to exposing this via the DC interfaces. I don't
> see an advantage of doing so offhand.

I'm going to leave it as is for now.


The webrev is udpated..


thanks,
-ethan




Reply via email to