On 01/28/10 04:42 PM, Joseph J VLcek wrote: > On 01/27/10 09:32 AM, Matt Keenan wrote: >> Code review request for bug : >> 12167 - GUI Installer Window Bar Icon Shows Up as Square Red X >> http://defect.opensolaris.org/bz/show_bug.cgi?id=12167 >> >> Webrev : >> http://cr.opensolaris.org/~mattman/bug-12167 >> >> Simple enough change to ensure default window icon for gui-install is >> set to >> correct system default of system-software-install. >> >> Also change user jack's home environment to not deliver a custom icon, >> as this >> icon should really be delivered by SUNWgnome-themes in nimbus theme, >> which it will via bug 14167. >> >> Bug is not a stopper and will only get pushed when slim_source gate has >> been split for 2010.03, just wanted to get code review completed so I >> could just push when the time comes. >> >> Tested on a DC built 131 ISO. >> >> cheers >> >> Matt >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > Looks OK Matt. > > I have a question. > > Is "system-software-install" the correct text to display here? Did you > confirm this with Frank Ludolph?
I'm not changing the text displayed in as the Window Title, I'm just setting the name of the default icon. "system-software-install" will not be displayed anywhere. Matt > This might not be an issue but it might be worth confirming with Frank. > I added Frank to the cc list. > > Joe
