Hi Alok,
Alok Aggarwal wrote: > Hi Jan, > > On Wed, 2 Sep 2009, Jan Damborsky wrote: > >> Hi Ethan, Sundar >> >> could I please ask one of you guys to review the fix for following bug ? >> Other reviewers are also welcome. >> >> 9549 Sparc AI client doesn't bring up network if not booted using DHCP >> >> * Webrev: >> http://cr.opensolaris.org/~dambi/bug-9549 >> >> Short story is that this fix add support for following scenarios: >> >> * Sparc Automated Installation without need for DHCP server >> (making Sparc AI more 'WAN') >> * Automated Installation of Sparc clients without wanboot support >> in OBP (wanboot binary loaded from media instead) >> >> Please see bug report for more details. >> >> Alok, as we were discussing during MPK work week, these modifications >> might affect bootable AI image (particularly refactoring SMF services >> part). >> Could you please take a look at those changes just to verify if there >> are any pieces which might be source of potential issues ? > > I just took a brief look at live-fs-root. A lot of this code has > been refactored out into a separate instance of the filesystem/root > service in my current wad for the Bootable AI. > > I can also send out a preliminary webrev of my changes to show > the refactoring looks like. If it is available, it would be nice - I might start to think about how the merge might look like. > > I don't see any problems with this code offhand but I'm wondering > if it would be possible to hold off on putting this CR back until > I've pushed my changes for Bootable AI? Sure, no problem. That seems reasonable to me. Thank you very much for looking at this ! Jan
