Hi Jack, Jack Schwartz wrote: > Hi Keith. > > Thanks for your response. My next iteration of replies is inline. > > I deleted any items with which I have no further comments. I've done the same > > On 09/16/09 09:35, Keith Mitchell wrote: >> >>> >>> 2.4.4: >>> >>> I suggest a different name than validate_partition_info, since the >>> method can change the info, more than just validate it. Maybe >>> validate_and_align_partition_info()? >> >> I frown upon really long function names. What do people think about >> just "resize_partitions" or "align_partitions"? > My vote is align_partitions().
Jean, since I believe you're a little more familiar with the specifics of what om_validate_and_resize_partitions() does, would be ok with align_partitions() and align_slices()? >>> I would suggest a very small (1 or 2), but non-zero grub timeout. >>> This way one can interrupt grub to change kernel parameters for >>> debugging purposes if necessary. IMO, a small timeout won't be a >>> nuisance and could be useful. >> That's a good point. We can set the "hiddenmenu" GRUB option, so >> users don't see the GRUB menu list, but can access it if they need to >> debug. In that case, perhaps a timeout of 5 seconds or so would be >> appropriate. > If the users don't see the grub menu, how will they know when/how to > interrupt the countdown and edit the entry? When the "hiddenmenu" GRUB option is active, the users see a blue screen with text across the top: "Press ESC to enter the menu... XX" where XX is how many seconds remain before the default option boots. - Keith > > Thanks, > Jack >
