Clay,
For completeness, I do think you also want to make this change in:
slim_source/usr/src/lib/install_utils/TreeAcc.py
Otherwise, LGTM.
To clarify, my understanding is that this fix is needed to ensure that
the behavior of the slim_source scripts remains the same regardless of
which version /usr/bin/python points to? While this makes sense as an
interim solution, it doesn't seem like the right answer for the long
term. Are you planning to fix 11380?
thanks,
Moriah
Clay Baenziger wrote:
> Hi Moriah,
> Yes, please code review 9804, as this wad will be unaffected by bug
> 11380.
> Thank you,
> Clay
>
> On Wed, 16 Sep 2009, Moriah Waterland wrote:
>
>> Clay,
>>
>> Are you still planning to putback fix for 9804 and do you still need a
>> code review for this? It wasn't clear to me if you were planning to
>> proceed with this putback or if you were going to table this fix until
>> you evaluate 11380. I will be happy to do the code review if you need
>> it, I just wanted to make sure that it will be useful.
>>
>> thanks,
>> Moriah
>>
>>
>>
>> Clay Baenziger wrote:
>>> Hi Danek,
>>> Thank you for the idea. I hadn't thought of striping out the #!'s
>>> for modules, etc. I found some files under /usr/lib/python2.4 are
>>> being execfile'd by other Python scripts, which makes it hard to tell
>>> what the heck's going on. So, I like this idea but expect it'll take
>>> some analysis and filed bug 11380 - "Should strip out unnecessary #!
>>> lines from Python files" for it.
>>>
>>> Thank you,
>>> Clay
>>>
>>> On Tue, 15 Sep 2009, Danek Duvall wrote:
>>>
>>>> Keith Mitchell wrote:
>>>>
>>>>> Is it worth leaving them in as a reference to which version of Python
>>>>> the modules are intended to run with? Or is there a better, more
>>>>> maintainable way?
>>>>
>>>> I don't think it's terribly worth it, no. If they're intended for
>>>> public
>>>> use, then they'll go into a versioned directory. If they're not,
>>>> then the
>>>> project they're part of should know what they're using.
>>>>
>>>> Danek
>>>>
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
