I need to get a code review for bug 11062. This has been tested using both manual tests to verify that it solves the issue as state in the bug and using the libbe automated test suite. All testing has completed successfully.
The bug: http://defect.opensolaris.org/bz/show_bug.cgi?id=11062 The webrev: http://cr.opensolaris.org/~evanl/11062/ Some background: This bug was caused by not checking for a return code from calls to zfs_promote. This was not checked originally based on invalid information and from looking at the use of zfs_promote in other areas of ZFS and other consumers of libzfs which don't check this output. What this lack of checking caused was a failure to activate a BE if there was a snapshot name that conflicted. This conflict could be caused if a zone was cloned using zoneadm clone and then an older BE with the original zone but without the new zone was activated. The fix adds checking for a failure from zfs_promote, the possible snapshot name conflict and changes the auto snapshot naming for zonesdataset to limit exposure to the possible naming conflict. Thanks! -evan
